Add mundialis linting workflow #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… warnings and infos
mmacata
reviewed
Dec 6, 2024
mmacata
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Great! Thank you!
There are some annotations from the docker build check, visible in the Files changed. Unfortuantely I can only make a suggestion via GitHub for one of them as the other lines are too far away from the changes. Would be cool to have these also fixed but not necessary to be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mundialis linting workflow:
pylintis not activated because; can be done in a later PR maybe with more ruff lintingBASH_SEVERITYis set to 'warning'VALIDATE_DOCKERFILE_HADOLINT(because only warnings and infos lead to error in pipeline)VALIDATE_JSONis not used because of templates which are not json valideVALIDATE_HTMLVALIDATE_CSSVALIDATE_BASH_EXEC